Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libpointmatcher_INCLUDE_DIR to match with CGAL #446

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Add libpointmatcher_INCLUDE_DIR to match with CGAL #446

merged 1 commit into from
Feb 12, 2021

Conversation

maximecharriere
Copy link
Contributor

When using libpointmatcher with CGAL, <pointmatcher/PointMatcher.h> can't be found because libpointmatcher is not added to the list of included directories.
The reason for this is that CGAL wait for the libpointmatcher_INCLUDE_DIR variable when libpointmatcher set the libpointmatcher_INCLUDE_DIRS variable (with a S)

CGAL_pointmatcher_support.cmake

if(libpointmatcher_FOUND AND NOT TARGET CGAL::pointmatcher_support)
  add_library(CGAL::pointmatcher_support INTERFACE IMPORTED)
  set_target_properties(CGAL::pointmatcher_support PROPERTIES
    INTERFACE_COMPILE_DEFINITIONS "CGAL_LINKED_WITH_POINTMATCHER"
    INTERFACE_INCLUDE_DIRECTORIES "${libpointmatcher_INCLUDE_DIR}"
    INTERFACE_LINK_LIBRARIES "${libpointmatcher_LIBRARIES}")

endif()

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

ok to test

@pomerlef pomerlef merged commit 7255005 into norlab-ulaval:master Feb 12, 2021
@pomerlef
Copy link
Collaborator

thanks!

@maximecharriere maximecharriere deleted the cmake/corrections branch February 12, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximecharriere @ethzasl-jenkins @pomerlef